Skip to content

fix(seo): escape backslashes in llms-full.txt comparison table cells - #8529

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/llms-full-backslash-escape
Oct 1, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
fix/llms-full-backslash-escape

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Escape backslashes before pipes in factCell so a fact value containing \ can't turn an escaped \| back into a column break in the /llms-full.txt comparison tables
  • Resolves CodeQL js/incomplete-sanitization alert on apps/sim/app/llms-full.txt/route.ts

Type of Change

  • Bug fix

Testing

bun run lint, bun run check:audits (53 audits), docs-manifest:check, type-check all pass; spot-checked the escaping in node (a\|b | c → a\\\|b \| c)

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Oct 1, 2026 6:11pm UTC

Request Review

@waleedlatif1
waleedlatif1 merged commit 52b9930 into staging Oct 1, 2026
21 of 22 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/llms-full-backslash-escape branch October 1, 2026 18:12
@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low risk] Fixes text escaping in a data export file.

The PR appears safe to merge, with a non-blocking regression-test gap for the escaping fix.

Findings

  1. P2 Escaping Fix Lacks Test ▶

Summary

The PR escapes existing backslashes before pipes when formatting comparison facts for /llms-full.txt.

  • This preserves pipe escaping when a fact contains both characters.
  • The new escape case lacks a regression test.

Reviews (1) · Last reviewed commit: "fix(seo): escape backslashes in llms-ful..."

const value = fact ? (fact.shortValue ?? fact.value) : 'Unknown'
return value.replace(/\|/g, '\\|').replace(/\s*\n\s*/g, ' ')
return value
.replace(/\\/g, '\\\\')

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Escaping Fix Lacks Test The new backslash-escaping case has no regression test, and the current comparison facts do not exercise it. A test with a literal backslash immediately before a pipe should check that the output remains a three-column Markdown row; without one, a later change to the escape order could silently bring back the table break this PR fixes.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

This branch was previously deployed

1 inactive deployment
Preview — 45c08f12 Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant