improvement(cron): run stale execution and file version cleanup off the request path by TheodoreSpeaks · Pull Request #8535 · simstudioai/sim

TheodoreSpeaks · 2026-10-01T19:09:06Z

Summary

Stale execution cleanup ran inline in the cron request; once the orphaned Chat run sweep was added, a run could outlast the cron executor's 50s request timeout, so the invocation errored and Lambda re-ran the whole job
Moved the cleanup body to a cleanup-stale-executions background task (background/cleanup-stale-executions.ts), unchanged apart from returning its summary instead of a response
Cron route now only enqueues the task and returns { triggered, jobId }, same pattern as cleanup-table-row-ttl: job id keyed to the 30-minute schedule window (a retry inside the window dedupes), concurrency 1, maxAttempts: 1 (the next tick is the retry)
cleanup-file-versions had the same problem through dispatchCleanupJobs, which pages every active workspace and resolves plans inline before fanning out chunks. Added a generic cleanup-dispatch task (background/cleanup-dispatch.ts, payload { jobType }) that runs the dispatcher in the worker; the route now only enqueues it, keyed to the day
Both routes still return 500 when the enqueue itself fails, so the cron error alarm keeps covering dispatch
Self-hosted database job backend runs the same functions in-process via the runner

Type of Change

Improvement

Testing

Existing stale-cleanup tests moved with the logic and call runCleanupStaleExecutions() directly; route tests cover enqueue failure and schedule-window dedupe through the route response
bun run lint, bun run check:audits (incl. api-validation) pass

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

https://claude.ai/code/session_015hKcjxj8i3bzASz9PDTFSX

vercel · 2026-10-01T19:09:12Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated
docs	Skipped		Oct 1, 2026 10:15pm UTC

cubic-dev-ai

No issues found across 6 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

greptile-apps · 2026-10-01T19:14:41Z

Confidence Score: 5/5

[High risk] Moves cleanup work from request handlers to background tasks.

No new blocking finding was established since the previous review.

Summary

The PR moves stale-execution cleanup and file-version dispatch out of cron requests and into background jobs.

Cron routes now enqueue window-keyed jobs and report enqueue failures.
The latest change adds dispatch retries and a task-level concurrency limit.
Existing cleanup tests were moved to exercise the background function directly.

_{Reviews (6) · Last reviewed commit: "fix(cron): retry and serialize cleanup d..."}

TheodoreSpeaks · 2026-10-01T19:26:58Z

@greptile

TheodoreSpeaks · 2026-10-01T19:26:59Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T19:27:06Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

TheodoreSpeaks · 2026-10-01T19:47:15Z

@greptile

TheodoreSpeaks · 2026-10-01T19:47:17Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T19:47:22Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

…onse

TheodoreSpeaks · 2026-10-01T20:24:09Z

@greptile

TheodoreSpeaks · 2026-10-01T20:24:10Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T20:24:16Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 7 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

TheodoreSpeaks · 2026-10-01T22:05:13Z

@greptile

TheodoreSpeaks · 2026-10-01T22:05:14Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T22:05:19Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

All reported issues were addressed across 10 files

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Fix all with cubic | Re-trigger cubic}

TheodoreSpeaks · 2026-10-01T22:15:42Z

@greptile

TheodoreSpeaks · 2026-10-01T22:15:43Z

@cubic-dev-ai review this PR

cubic-dev-ai · 2026-10-01T22:15:49Z

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai

No issues found across 10 files

Confidence score: 5/5

Automated review surfaced no issues in the provided summaries.
No files require special attention.

_{You've manually re-run cubic several times on this PR. Each manual re-review checks the full PR again and counts toward your usage quota. To preserve your usage limits, we recommend letting cubic automatically review new commits.
Tip: cubic can generate docs of your entire codebase and keep them up to date. Try it here.

Re-trigger cubic}

improvement(cron): run stale execution cleanup as a background task

9be5137

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.ts

fix(cron): run sync-log retention test against the cleanup task

10e0373

vercel Bot temporarily deployed to Preview October 1, 2026 19:26 Inactive

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.test.ts Outdated

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

fix(cron): assert stale cleanup route by its response only

e092a9a

vercel Bot temporarily deployed to Preview October 1, 2026 19:47 Inactive

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-stale-executions/route.test.ts

fix(cron): cover stale cleanup dispatch window through the route resp…

8cd3f0d

…onse

vercel Bot temporarily deployed to Preview October 1, 2026 20:24 Inactive

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

improvement(cron): dispatch file version cleanup from a background task

4d0974d

vercel Bot temporarily deployed to Preview October 1, 2026 22:05 Inactive

TheodoreSpeaks changed the title ~~improvement(cron): run stale execution cleanup as a background task~~ improvement(cron): run stale execution and file version cleanup off the request path Oct 1, 2026

greptile-apps Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-file-versions/route.ts Outdated

Comment thread apps/sim/background/cleanup-dispatch.ts

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

Comment thread apps/sim/app/api/cron/cleanup-file-versions/route.ts

fix(cron): retry and serialize cleanup dispatch on the task definition

078e466

vercel Bot temporarily deployed to Preview October 1, 2026 22:15 Inactive

cubic-dev-ai Bot reviewed Oct 1, 2026

View reviewed changes

TheodoreSpeaks merged commit 320843e into staging Oct 1, 2026
59 of 60 checks passed

TheodoreSpeaks deleted the debug/cron-fire branch October 1, 2026 22:47

waleedlatif1 mentioned this pull request Oct 1, 2026

v0.9.10: geo, chat fixes, sandbox fixes #8539

Merged

Conversation

TheodoreSpeaks commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Type of Change

Testing

Checklist

Uh oh!

vercel Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

Uh oh!

Uh oh!

cubic-dev-ai Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

TheodoreSpeaks commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot commented Oct 1, 2026

Uh oh!

cubic-dev-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This branch was previously deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

TheodoreSpeaks commented Oct 1, 2026 •

edited

Loading

vercel Bot commented Oct 1, 2026 •

edited

Loading

greptile-apps Bot commented Oct 1, 2026 •

edited

Loading

cubic-dev-ai Bot left a comment •

edited

Loading