Repository navigation
refactor(mothership): a saved Stop handoff's id wins on restore - #8747
Merged
Merged
Conversation
When an entry saved with an id on its Stop handoff also has its own resumeUserMessageId, the handoff's id is the one that build sent, so it is the one kept. resumeUserMessageId's doc names every path that sets it.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Collaborator
Author
Collaborator
Author
|
@cubic-dev-ai review this PR |
Contributor
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #8746, from its review. No behaviour change for anything staging can produce.
resumeUserMessageId. Where an entry also had its ownresumeUserMessageIdand the two differed, it kept the entry's. It now keeps the seed's. That is the id the build that saved the entry sent:queuedSendHandoff?.userMessageId ?? resumeUserMessageId. Staging never produces two different ids, but the mapping now matches it exactly.resumeUserMessageId's doc comment names every path that sets it. Besides a send an unmount withdrew, these are:Type of Change
Testing
moves the reused id a saved Stop handoff carried onto the entry, over its own(store.dom.test.ts) gains an entry carrying both ids. It fails on staging.Checklist