Repository navigation
fix(ci): count both sides of a rename in the desktop live gate, keep canary reports - #8751
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI review findings from #8748.
desktop-live-changes.sh:git diff --name-onlylists only a rename's destination, so moving a live file into a skipped path (apps/docs/,.md, ...) skipped the live desktop suite. It now diffs with--no-renames, so both the deleted source and the added destination count.desktop-e2e.yml: the electron@latest canary's Playwright step now sets the sameBACKGROUND_EXECUTOR_REPORT_PATH/TERMINAL_CANCEL_REPORT_PATHas the pinned job, so its uploadedtest-resultsinclude the JSON diagnostics.Type of Change
Testing
scripts/desktop-live-changes.test.tsruns the script against a temp clone with a local bareorigin: renameapps/sim/x.ts->apps/docs/x.tsgiveschanged=true(fails withchanged=falsewithout--no-renames), docs-only giveschanged=false, an unfetchable base giveschanged=true.bun run test:scripts: 33 files, 357 tests pass.actionlintclean ondesktop-e2e.yml.Checklist