Skip to content

chore(config): retire unused env vars and fully-rolled-out feature flags - #8808

Merged
waleedlatif1 merged 2 commits into
stagingfrom
chore/retire-unused-env-flags
Oct 8, 2026
Merged

waleedlatif1 merged 2 commits into
stagingfrom
chore/retire-unused-env-flags

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • Removed 14 env vars that nothing reads: AGENT_INDEXER_URL/_API_KEY, APOLLO_API_KEY, DISCORD_CLIENT_ID/_SECRET, SUPABASE_CLIENT_ID/_SECRET, STRIPE_PRO|TEAM|ENTERPRISE_PRICE_ID, JOB_RETENTION_DAYS, KB_CONFIG_CHUNK_CONCURRENCY, S3_LOGS_BUCKET_NAME, NEXT_PUBLIC_WORKFLOW_COLUMNS_ENABLED
  • Retired the tables-v2-api flag: the typed table query route, its requireV2Feature gate, the tables_v2_disabled 403 and the operationAvailability rollout hint are gone. The route is now always available, still behind its normal authorization
  • Retired the table-row-ttl flag: TTL columns and the expired-row cleanup are always on. Removed the ttl-availability module, TableRowTtlDisabledError, the prop that carried the flag to the table UI, and TABLE_ROW_TTL from Helm and .env.example
  • Retired the credential-groups AppConfig flag. On hosted, an Enterprise plan alone decides access. On self-hosted it's now a credentialGroups enterprise entitlement: off by default, turned on by CREDENTIAL_GROUPS (same var as before) or ENTERPRISE_ENABLED
  • Deleted getWorkspaceOrganizationId (its only callers were the removed gates) and dropped the gate-only tests and mocks
  • Kept the optional operationAvailability field on the mothership block-detail schema because mothership's contract still declares it

Type of Change

  • Chore / cleanup

Testing

  • bun run test at the root: all pass (36,595 in apps/sim)
  • bun run lint, bun run type-check, bun run check:audits, docs-manifest:check, block-registry check against origin/staging, and CI's env-flag validation block
  • I didn't run the TTL cleanup integration tests locally (they need Postgres). I only removed their flag mock and the disabled-feature step

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

🤖 Generated with Claude Code

@vercel

vercel Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Oct 8, 2026 7:48pm UTC

Request Review

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 69 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The PR appears safe to merge based on the changes since the previous review and the full-PR rules check.

Summary

Removes unused environment settings and retires three completed feature rollouts.

  • Typed table queries and row expiration are always available.
  • Credential Groups requires Enterprise on hosted deployments. Self-hosted deployments use CREDENTIAL_GROUPS or ENTERPRISE_ENABLED.
  • Removes obsolete gates, tests, and mocks.
  • Since the previous review, only the Helm chart version changed, from 1.11.7 to 1.11.8. No actionable issue was found in that change or the full-PR rules check.

Reviews (2) · Last reviewed commit: "chore(helm): bump chart version for remo..." · Reviewed by Greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 70 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit b45bbf3 into staging Oct 8, 2026
37 of 38 checks passed
@waleedlatif1
waleedlatif1 deleted the chore/retire-unused-env-flags branch October 8, 2026 19:45

This branch was successfully deployed

1 active deployment
Preview — 3d23dfad Deployed Oct 8, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant