Repository navigation
Conversation
badrogger
marked this pull request as ready for review
October 8, 2026 18:15
badrogger
requested review from
a team,
dmytrotkk and
kladkogex
as code owners
October 8, 2026 18:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
rpc-proxycommand for all node types (active and passive, for both standard and Fair nodes) to control whether sChain RPC ports are served by nginx, along with supporting documentation and infrastructure changes. It also updates the firewall (nftables) logic to dynamically manage TLS service ports based on certificate presence, and refactors nginx configuration paths for improved maintainability.New CLI command for RPC proxy management:
rpc-proxycommand (node_cli/cli/rpc_proxy.py) to the CLI for all node types, allowing users to override on a per-node basis whether sChain RPC ports are served by nginx or not (on,off, ordefault). This command is now included in the command groups for standard nodes, passive nodes, Fair nodes, and passive Fair nodes. [1] [2] [3] [4] [5] [6] [7] [8] [9]Documentation updates:
README.mdto document the newrpc-proxycommand for all relevant node types, including usage, arguments, and operational notes about when changes take effect. [1] [2] [3] [4]Nginx configuration improvements:
Firewall (nftables) enhancements:
sync_tls_acceptsmethod and async_tls_portsfunction to keep the firewall in sync with certificate state. [1] [2] [3]Other infrastructure and bugfixes:
nftables.pyfor code clarity and maintainability. [1] [2] [3]