JAIPilot campaign evaluation: Vert.x #6329 - #1
Open
skrcode wants to merge 2 commits into
Open
Conversation
… request body completes When the server sends an early response (before the full request body is received) and the client then closes the connection, the request metrics never receive requestEnd or requestReset, causing the active-request gauge to retain the request forever. The root cause is that Http1ServerConnection.handleClosed() only cleans up metrics for responseInProgress, but not for requestInProgress when the request body never completed (no LastHttpContent received). This fix ensures that requestReset is called on the pending request metric when the connection is closed with an incomplete request body. Fixes eclipse-vertx#6328
…lose Add a test that sends a GET with Content-Length but no body, has the server respond early (401), and then closes the connection. Asserts that the request metric's failed flag is set (requestReset was called), confirming the active-request gauge does not leak. Related to eclipse-vertx#6329 (fix for eclipse-vertx#6328)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exact cloud-only evaluation mirror of eclipse-vertx#6329
Exact upstream head: e828fb6
JAIPilot must return at most one small, behavior-preserving, independently provable companion draft or leave this PR unchanged. No repository build is being run on a developer laptop.