SK-3006: Add FlowDB reveal/collect support, typed callbacks, updated samples and README - #188
Merged
saileshwar-skyflow merged 12 commits intoJul 29, 2026
Conversation
- Add FlowDBAPIClient, FlowDBCollectAPICallback, FlowDBCollectRequestBody, FlowDBMixedAPICallback for v2 insert/update/upsert API - Add FlowDBRevealApiCallback, FlowDBRevealRequestBody, FlowDBRevealRequestRecord for v2 detokenize API (reads "response" array, handles per-token httpCode) - Add UpdateType and UpsertOptions for upsert and update-by-skyflowID support - Update RevealElementInput: redaction changed from RedactionType enum to String to support custom vault redaction names - Update RevealValueCallback: fix key naming (records/errors), handle missing token field in error records gracefully - Update Client, CollectContainer, ComposableContainer, Configuration to wire FlowDB API client and support new collect/reveal options - Update collect/reveal containers and element inputs for FlowDB contract - Update tests to reflect FlowDB API changes; remove obsolete connection tests
- Add typed RevealCallback/RevealResponse for reveal operations - Add typed CollectCallback/CollectResponse for collect operations - Add CollectOptions with upsert (UpsertOptions/UpdateType) and additionalFields (AdditionalFields/AdditionalFieldsRecord) - Rename internal SkyflowError to SkyflowInternalError; add public SkyflowError data class - Update samples: CollectActivity (insert/upsert/additionalFields), RevealActivity (reveal/reveal-with-options), ComposableActivity, InputFormattingCollect/Reveal, CardBrandChoiceActivity all use typed callbacks - Remove obsolete sample activities: UpsertFeature, UpdateCollectActivity, UpdateComposableActivity - Update activity_collect.xml, activity_reveal.xml, activity_main.xml layouts - Add ResponseTest.kt unit tests for new response types - Update README with typed callback sections (Android + iOS snippets) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
saileshwar-skyflow
changed the title
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
skyflow-bharti
approved these changes
Jul 29, 2026
yaswanth-pula-skyflow
approved these changes
Jul 29, 2026
- Remove "Inserting data into the vault" section (skyflowClient.insert) - Remove "Retrieving data from the vault" section (detokenize/getById/get) - Remove old end-to-end examples using InsertCallback and JSONObject/JSONArray options - Update Step 4 collect/update in both Elements and Composable sections to use typed CollectCallback and new CollectOptions/AdditionalFields API - Add iOS (Swift) snippets alongside Android (Kotlin) in all Step 4 blocks Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Devesh-Skyflow
approved these changes
Jul 29, 2026
- Remove `redaction` from RevealElementInput docs (field was deleted from SDK) - Remove stale notes about invokeConnection() and RedactionType defaults - Step 4 reveal: replace old untyped Skyflow.Callback with typed RevealCallback (Android + iOS) - End-to-end reveal example: remove redaction from elements, use typed RevealCallback - Update sample response to new flat records format with httpCode per record - Fix skyflowID → skyflowId in CollectElementInput parameter docs - Fix collect() method signature references: Skyflow.Callback → CollectCallback - Remove deleted `tokens` option from CollectOptions descriptions Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Android README should only contain Android (Kotlin) examples. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
These headings were added to pair with iOS Swift blocks that have since been removed. Not needed in a single-platform README. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The server returns "" for tableName on partial-error records. The SDK backfills tableName from the original request using a pre-built ordered list, so CollectRecord.tableName is never empty in the callback. Updated the README partial error response sample to show tableName populated as delivered to the callback. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- dispatchResponse: store token data under "tokens" key (not "fields") - CollectResponse.fromJson: read from "tokens" key to match - README: replace "fields" with "tokens" in sample response, add path field to token objects, merge success/partial-error into one sample showing both as CollectRecord in the same records list Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RevealCallback/RevealResponseandCollectCallback/CollectResponsereplacing old untypedCallbackCollectOptionswithupsert(UpsertOptions/UpdateType) andadditionalFields(AdditionalFields/AdditionalFieldsRecord)SkyflowError→SkyflowInternalError; expose publicSkyflowErrordata class (grpcCode,httpCode,message,httpStatus,details)error: SkyflowErrorinonFailureUpsertFeature,UpdateCollectActivity,UpdateComposableActivityResponseTest.ktunit tests for new response types