SK-2986 use admin service-account PAT for release version-bump push (v1) - #373
Merged
Merged
Conversation
Same fix as #371 (main) / #372 (v3), applied to the v1 branch's copy of shared-build-and-deploy.yml. The v1 release pipeline (release-v1.yml) pushes the version-bump commit directly to the protected v1 branch (git push origin HEAD:v1) as github-actions[bot], which is not a ruleset bypass actor, so the push would be rejected. Point the release checkout at PAT_ACTIONS (skyflow-service-it, a repo admin) so its credential is persisted and reused for the push, which then satisfies the ruleset's repo-admin bypass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third of three, matching #371 (main) and #372 (v3). Applies the fix to the v1 branch's copy of
shared-build-and-deploy.yml.Why
Branch protection now enforces PR + approval + the
Testcheck onmain/v1/v3. The v1 release pipeline (release-v1.yml→ shared workflow) pushes the version-bump commit directly to the protectedv1branch (git push origin HEAD:v1) asgithub-actions[bot], which is not a ruleset bypass actor — so the push would be rejected and v1 releases would break.What
Point the release
actions/checkoutatPAT_ACTIONS(skyflow-service-it, a repo admin). The persisted credential is reused for the bump push, satisfying the ruleset's Repository Admin bypass.Requires
PAT_ACTIONSto be owned by a repo-admin account with Contents: write. It is currently used only for the read-only commit-message checker — confirm its scope, or switch to a purpose-built write-capable token. See #371 for the full discussion (incl. the alternative of dropping the version-bump push entirely).Ref: SK-2986
🤖 Generated with Claude Code