SK-2986 fix v3 release: pass PAT_ACTIONS into reusable workflow - #375
Merged
Devesh-Skyflow merged 1 commit intoJul 29, 2026
Merged
Conversation
The checkout step in shared-build-and-deploy.yml uses
`token: ${{ secrets.PAT_ACTIONS }}`, but that step runs inside a reusable
(workflow_call) workflow. Reusable workflows do not inherit the caller's
secrets, and PAT_ACTIONS was neither declared as a workflow_call secret nor
passed by any caller — so it resolved to empty and actions/checkout failed
with "Input required and not supplied: token".
Declare a `pat-actions` workflow_call secret and pass it explicitly from all
three callers (internal-release, release, beta-release), matching the existing
secret-passing pattern.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 29, 2026
…loop fix [skip ci] Squashes the release-only history on top of v3 (ceae600) into one commit: - SK-3023 configurable connect/read/write timeouts for v3 (#374) - SK-2986 pass PAT_ACTIONS into reusable workflow via workflow_call secret (#375) - SK-3023 fix internal-release infinite loop via [skip ci] on the bump commit (#377) - the automated dev version bumps (folded in) Version: 3.0.0-beta.12-dev.6d1831b. Tree is unchanged from f2eb507. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Devesh-Skyflow
added a commit
that referenced
this pull request
Jul 29, 2026
* SK-3023 v3-release/26.7.29: configurable timeouts + internal-release loop fix [skip ci] Squashes the release-only history on top of v3 (ceae600) into one commit: - SK-3023 configurable connect/read/write timeouts for v3 (#374) - SK-2986 pass PAT_ACTIONS into reusable workflow via workflow_call secret (#375) - SK-3023 fix internal-release infinite loop via [skip ci] on the bump commit (#377) - the automated dev version bumps (folded in) Version: 3.0.0-beta.12-dev.6d1831b. Tree is unchanged from f2eb507. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * SK-3023 guard internal-release against the automated bump commit (v3 release) Replaces the skip-ci approach with a scoped job guard so the PAT-authored version bump cannot re-trigger the release, without globally skipping CI (so PR checks run again). - internal-release.yml: skip the job when the head commit is an automated bump - shared-build-and-deploy.yml: drop the skip-ci suffix from the bump commit Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * [AUTOMATED] Private Release 3.0.0-beta.12-dev-cad9a33 --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Co-authored-by: Devesh-Skyflow <Devesh-Skyflow@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
build-and-deploy-v3 / publishjob fails at the very first step (actions/checkout@v2) with:The checkout step supplies
token: ${{ secrets.PAT_ACTIONS }}(added in #372 / SK-2986 so the persisted admin PAT can push the automated version bump past branch protection). But that step lives inside the reusable workflowshared-build-and-deploy.yml(workflow_call). Reusable workflows do not inherit the caller's secrets — a secret is only visible if it is declared inworkflow_call.secretsand passed by the caller.PAT_ACTIONSwas neither declared nor passed, so it resolved to empty and checkout hard-failed.Fix
Matches the repo's existing secret-passing pattern:
shared-build-and-deploy.yml: declare apat-actionsworkflow_callsecret; checkout now usestoken: ${{ secrets.pat-actions }}.pat-actions: ${{ secrets.PAT_ACTIONS }}from all three callers:internal-release.yml,release.yml,beta-release.yml.All four workflow files validated as YAML.
Note (out of scope)
shared-build-and-deploy.ymlalso references${{ secrets.TEST_CREDENTIALS_FILE_STRING }}directly (create-json step) without declaring/passing it, socredentials.jsonis built empty. The job currently dies at checkout before reaching it. Left for a separate change.🤖 Generated with Claude Code