Switch main internal-release to the automated-bump guard (fixes #378 leftover) - #380
Open
Devesh-Skyflow wants to merge 1 commit into
Open
Switch main internal-release to the automated-bump guard (fixes #378 leftover)#380Devesh-Skyflow wants to merge 1 commit into
Devesh-Skyflow wants to merge 1 commit into
Conversation
#378 merged the earlier skip-ci version before it was converted to the guard, so main is still on the bandage and inconsistent with the v3 line. This switches main to the scoped guard: the release job is skipped when the triggering push's head commit is an automated bump, so the PAT-authored bump cannot re-trigger the release, without globally skipping CI. - internal-release.yml: add the head-commit guard on the automated bump marker - shared-build-and-deploy.yml: drop the skip-ci suffix from the bump commit
|
✅ Gitleaks Findings: No secrets detected. Safe to proceed! |
|
Semgrep Findings: Issues with Error level severity are found (Error is Highest severity in Semgrep), Please resolve the issues before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#378 merged before it was converted from the skip-ci workaround to the scoped guard, so
mainis still on the bandage and inconsistent with the v3 line (which now uses the guard). This correctsmain.Change
internal-release.yml: addif: ${{ !contains(github.event.head_commit.message, '[AUTOMATED]') }}to thebuild-and-deployjob — the automated version-bump commit can no longer re-trigger the release (the loop), while PR CI and all other workflows still run.shared-build-and-deploy.yml: drop the skip-ci suffix from the bump commit message (the guard replaces it).Why the guard, not skip-ci
skip ciis global — it suppresses every workflow on the commit, including PR checks (that's the bug we hit on the release PR). The identity/marker guard is scoped to internal-release only.Validated live on the v3 line: real commit → release ran; the automated bump it pushed was skipped (no loop), and PR CI ran normally.
🤖 Generated with Claude Code