Repository navigation
fix: detect config changes for require_mcp_auth and handle residual edge cases - #1484
AdamMagued wants to merge 2 commits into
Conversation
Detect changes to require_mcp_auth and related hot-reloadable fields in DetectConfigChanges, propagate missing config errors in registry commands, apply TLS and listen environment overrides on fallback CLI loaders, redact credentials following apostrophes in doctor URLs, and return an empty preview for empty JSON imports.
8973ed7 to
9748de8
Compare
…t-reload handling Resolve conflicts to main's side (explicit -c error, ApplyEnvOverrides, apostrophe-tolerant doctor URL pattern). Drop the redundant production hunks in config_hotreload.go and httpapi/import.go that main already covers. Make debug_search assert restart-gated and tighten ChangedFields assertions to exact matches.
|
Hi @AdamMagued, thank you for this, and for going back through #1466 for the leftover edge cases. You found six real gaps: I owe you an apology for the timing. While your PR was open, several maintainer PRs (#1435, #1472, #1496, #1505, #1529) fixed the same residuals in almost the same way. Sorry we duplicated your work instead of landing yours first. As a result, this branch now conflicts with
Your tests are still valuable. They lock in the behaviour for every residual you found, and nothing else covers that. So rather than ask you to redo anything, I pushed these small changes to your branch as maintainer, keeping your authorship:
With those changes the PR becomes a regression-test PR covering all of the #1466 residuals, and I'll merge it once CI passes. Thanks again for the careful audit and the tests. If you'd like to pick up more, I'd be glad to point you at an open issue, and I'll try to move faster on your next one. |
|
Thanks @Dumbris. The merge and assertion adjustments make complete sense with main's architecture—especially retaining restart-gated semantics for debug_search and tightening the ChangedFields assertions to exact matches. I have verified the branch against the test suite, and all regression tests pass cleanly. Appreciate you preserving test authorship and keeping the coverage intact. |
Fixes #1466
This change addresses residual issues identified during the Spec 108/109 review: