Repository navigation
fix(cli): agent-instructions follow-ups from zcode review of #1486 - #1487
Merged
Merged
Conversation
…pstream_servers when management is off zcode review of #1486 (all low): - agent-instructions silently printed the retrieve_tools workflow when the config failed to load; it now warns on stderr like --with-servers does. - the default snippet always prescribed upstream_servers, which disable_management / read_only_mode remove from the surface; it is now omitted when management tools are off. - move CompiledPolicy.HasAllowRules below Decide so Decide keeps its godoc.
Deploying mcpproxy-docs with
|
| Latest commit: |
2779cf5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48473b60.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-agent-instructions-fo.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37131941385 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes three LOW findings from the zcode (GLM-5.3) review of #1486:
cmd/mcpproxy/agent_instructions_cmd.go):mcpproxy agent-instructionsused to discard a config load error and print the default retrieve_tools workflow with exit 0. It now warns on stderr, the same way--with-serversalready does.upstream_serversline: the default snippet always said to useupstream_servers. Withdisable_managementorread_only_modethat tool is absent (internal/server/mcp.gomanagement guard), so the line is now omitted in that case.internal/profile/policy.go):HasAllowRuleshad been inserted insideDecide's doc comment, soDecidelost its godoc. The method now sits belowDecide. No behaviour change.Not needed for v0.70.0-rc.3.
Testing
New test:
TestBuildAgentInstructions_OmitsUpstreamServersWithoutManagement.go test ./cmd/mcpproxy/ -run AgentInstructionsand./internal/profile/pass.🤖 Generated with Claude Code