Repository navigation
ci(release): summarize a stable release since the previous stable tag - #1491
Merged
Merged
Conversation
generate-notes found the previous tag with 'git describe --tags HEAD^',
which after an RC cycle is the last RC, so a stable release was
summarized as only its final RC delta: v0.70.0's notes covered rc.4..rc.5
and missed profiles v3, per-client credentials and agent visibility.
Exclude prerelease tags ('*-*') when looking up the previous tag for a
stable release, in release.yml's generate-notes job and in
scripts/generate-release-notes.sh (RC tags keep comparing with the
nearest tag of any kind).
Deploying mcpproxy-docs with
|
| Latest commit: |
10570f8
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://402bc6fd.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://claude-release-notes-skip-rc.mcpproxy-docs.pages.dev |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
The v0.70.0 release notes covered only the rc.4 → rc.5 fixes, described the release as "stability improvements", and missed profiles v3, per-client credentials and agent visibility. I rewrote them by hand after the release.
Cause.
release.yml'sgenerate-notesjob finds the previous tag withgit describe --tags --abbrev=0 HEAD^. After an RC cycle, the nearest tag is the last RC, so the commit range sent to the summarizer wasv0.70.0-rc.4..v0.70.0, notv0.69.0..v0.70.0.Fix. Exclude prerelease tags (
--exclude '*-*') when looking up the previous tag:release.yml, thegenerate-notesjob, which runs for stable tags only.scripts/generate-release-notes.sh, used for local runs: stable tags get the same exclusion, and RC tags keep comparing with the nearest tag of any kind.The release notice problem is separate and not changed here. It comes from the unmerged retire PR #1362.
Testing
get_previous_tagagainst real tags returns:v0.70.0v0.69.0(was rc.4/rc.5)v0.70.0-rc.5v0.70.0-rc.4v0.70.0-rc.2v0.70.0-rc.1v0.69.0v0.68.0The workflow expression, simulated at
v0.70.0, returnsv0.69.0.bash -nand a YAML parse both pass. There is no test harness for the release workflow.🤖 Generated with Claude Code