Repository navigation
fix(clients): harden connect credential commit/abort ordering and offline reconcile - #1494
Merged
Merged
Conversation
…aims, offline reconcile (refs #1451) - Commit applies the requested binding before finalizing the rotated secret and restores the previous binding if finalize fails (1451-1). - The in-flight connect claim carries a per-connect token; Release/Abort act only for the owning connect, and Abort refuses when the pending secret is no longer the one it issued (1451-16). - The offline connect backend wires the config reader and reconciles the client before issuing (1451-2).
Deploying mcpproxy-docs with
|
| Latest commit: |
7d4940b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://39143dd9.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-b4-backend-runtim.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37301100323 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardened the connect credential commit/abort ordering to prevent partial state transitions during binding reconciliation, and improved offline reconcile recovery through best-effort binding restoration.
Fixed Items
TestConnectCredentialAtomicity,TestOfflineBindingReconcile,TestTokenClaimScopeReview Status
Clean after 1 round(s). One open finding (low priority, deferred):
Refs #1451