Repository navigation
fix(server): keep MCP session attribution across unregister/re-register - #1497
Merged
Merged
Conversation
…er/re-register (refs #1205) RemoveSession now marks the session closed and keeps client name, workspace, persisted flag and work session; the next activity or register hook revives it (re-opening the stored record without a duplicate), and closed entries are evicted after 30 minutes. Rewrites the stale unregister-hook comment.
Deploying mcpproxy-docs with
|
| Latest commit: |
5b85044
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://100a7744.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-b2-backend-server.mcpproxy-docs.pages.dev |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37303843438 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RemoveSession now marks sessions as closed and retains client identity, workspace, and persisted flags for up to 30 minutes. The next activity or register hook revives the entry (opening the stored record without duplicating it), preserving MCP session attribution across unregister/re-register cycles.
Fixed Items
Test: E2E API suite passes (63/66 tests; 3 skipped server-edition tests). Session lifecycle and attribution preservation covered by existing activity and register tests.
Review Status
Clean after 1 round. Deferred finding (low-priority, non-blocking):
Closes
Closes #1205