Skip to content

fix(web): clients/profiles stale-async and scope-list fixes (Spec 108-i follow-ups) - #1500

Merged
Dumbris merged 5 commits into
mainfrom
fix/issues-b8-frontend
Oct 5, 2026
Merged

Dumbris merged 5 commits into
mainfrom
fix/issues-b8-frontend

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026

Copy link
Copy Markdown
Member

Summary

Fix stale async state and scope-list UI issues in the Clients and Profiles pages. Addresses refresh token handling, preview state management, and scope visibility edge cases identified in Spec 108-i follow-up review.

Changes

  • glm:1.F1: Hidden error on preview re-fetch failure — add error display in preview panel
  • glm:1.F2: startConnect clears previewStale but never resets it on fetch failure — fix state tracking
  • glm:3.1: Preview re-fetch throws without writing error — catch exceptions and display message
  • glm:3.2: Late-landing startConnect overwrites fresh preview state — add ticket validation
  • glm:1.2: applyAll clears stale flag unconditionally outside success check — fix indentation
  • glm:2.2: previewRefreshing and previewTickets not reset on reopen — reset in watch handler

Review Status

Clean after 4 rounds. Open findings (not addressed in this batch):

  • glm:1.1 (medium): getRouting response discarded when load() superseded by concurrent refreshPresence()
  • glm:2.1 (medium): Acceptance 7 unmet on preview re-fetch failure path — old token retained
  • glm:1.2 (low): Already partially fixed (indentation) but related race noted
  • glm:2.2 (low): Reopen watch partial fix — remaining edge cases

All findings tracked for future work; this PR stabilizes the immediate UX issues.

Refs #1446

Shared GET /clients ticket, unscoped roster for the sidebar badge, assign
dialog and profiles page, per-client preview tickets with Connect disabled
while a changed intent refreshes, refusal clearing on success and cancel,
BulkMove counting/failed state with per-open ticket, AgentTokens load ticket
and a non-wrapping Profile chip (items 3,4,6,7,8,11,12,13,14,17).
… preview refresh failure and reopen guards (refs #1446)
…h, clear error on Cancel, keep Connect disabled when reopen fetch fails (refs #1446)
@Dumbris
Dumbris enabled auto-merge (squash) October 5, 2026 12:29
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3ab5942
Status: ✅  Deploy successful!
Preview URL: https://a741337c.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-b8-frontend.mcpproxy-docs.pages.dev

View logs

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/issues-b8-frontend

Available Artifacts

  • archive-darwin-amd64 (31 MB)
  • archive-darwin-arm64 (28 MB)
  • archive-linux-amd64 (19 MB)
  • archive-linux-arm64 (17 MB)
  • archive-windows-amd64 (31 MB)
  • archive-windows-arm64 (27 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (27 MB)
  • installer-dmg-darwin-arm64 (24 MB)
  • smart-mcp-proxymcpproxy-goYHI0XS.dockerbuild (0 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 37309813582 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit 907f4e2 into main Oct 5, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants