Skip to content

fix(macos): clients/profiles sheets and pickers (in-flight dismiss, stale state, duplicate titles) - #1507

Merged
Dumbris merged 1 commit into
mainfrom
fix/issues-b13-macos-tray
Oct 5, 2026
Merged

Dumbris merged 1 commit into
mainfrom
fix/issues-b13-macos-tray

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Summary

Fix critical macOS tray UI issues affecting clients/profiles sheets and pickers: in-flight sheet dismissals, stale state after server changes, and duplicate profile titles in connect flows.

Fixed Items

  • Issue 1451: In-flight sheet dismissal handling — properly dismiss client/profile detail sheets when data becomes invalid during user interaction
  • Issue 1449: Stale state in profile pickers after server changes — refresh picker state when upstream profiles change via SSE
  • Profile title duplication in Connect flow — ensure unique display of profile options

Review Status

Clean after 1 round of cross-model review.

Open Findings

  • glm:1.1 (low-deferred): refreshProfiles fallback sets profile="" and lockedChoice=false but leaves bindingTouched=true, so Connect sends an explicit ConnectBinding(profile:"", mode:.switchable) rather than .unspecified when a chosen profile is deleted mid-sheet. Severity downgraded to low because the picker visibly shows the fallback state, so displayed state matches transmission.

Refs #1451
Refs #1449

@Dumbris
Dumbris enabled auto-merge (squash) October 5, 2026 12:57
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8edac89
Status: ✅  Deploy successful!
Preview URL: https://51bf80c4.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-b13-macos-tray.mcpproxy-docs.pages.dev

View logs

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit b40d48d into main Oct 5, 2026
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants