Repository navigation
feat(server): private short-lived MCP cache hints on list/read results (Spec 113-f) - #1510
Merged
Merged
Conversation
…ead results (Spec 113-f) Spec 058 FR-019 (T063/T064): configure mcp-go WithCacheHints and WithMethodCacheHints explicitly. Every mcpproxy listing is filtered per caller (profile, agent-token scope, quarantine), so cacheScope is private and ttlMs is a short 5s window.
Deploying mcpproxy-docs with
|
| Latest commit: |
594ad4d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://21f15394.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://113-f-mcp-cache-hints.mcpproxy-docs.pages.dev |
The hints were only set on p.server; /mcp, /mcp/all, /mcp/code and /mcp/call are served by the routing-mode servers, which did not carry them.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37439871806 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
enabled auto-merge (squash)
October 6, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Spec 058 FR-019 requires
ttlMsandcacheScopeon list/read results. mcp-go v1.0.0 emits them (SEP-2549) with a library default of ttl 0 / private; mcpproxy never configured them explicitly, so scope and TTL were an unpinned library default. Talk gap G9.What changed
cacheHintServerOptions()ininternal/server/mcp.go:WithCacheHintsplus per-methodWithMethodCacheHints(tools/list, prompts/list, resources/list, resources/templates/list, resources/read, server/discover), allprivate, ttl 5000 ms.internal/server/cache_hints_test.go: drives a modern-era request and asserts private scope and the short TTL on each list method.Tests
go test -raceinternal/server/... passes, bare and-tags server, with the CI skip regex.scripts/test-api-e2e.sh(the change only adds server options; the shared machine was saturated).Assumptions
Spec: #1495
Review: opencode github-copilot/gpt-6.1-sol, 2 rounds, clean; follow-ups: hints are inert on the production transport until the FR-028 legacy-era pin is lifted (test uses an unpinned transport)