Repository navigation
test(e2e): SIGTERM-mid-run abort mode for test-api-e2e-cleanup-check.sh - #1514
Merged
Merged
Conversation
Dumbris
enabled auto-merge (squash)
October 5, 2026 13:30
Deploying mcpproxy-docs with
|
| Latest commit: |
8a0ddc2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2cc15761.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-b17-tests.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Dumbris
added a commit
that referenced
this pull request
Oct 6, 2026
… PRs (#1521) ## Summary Low-severity follow-ups from review of the catalog (#1508), telemetry and e2e cleanup PRs (#1514). - L1 (catalog review): `domainLabelMatchesOwner` rejects TLD and second-level suffix words (com, org, net, gov, edu, co, ac, io), so `com.org.evil/x` no longer verifies as owner `org` against `acme-org`. Test: `TestDomainLabelMatchesOwner_RejectsTLDWords`. - L2 (telemetry review): `TestStatus_ReportsListenAddr` pinned `:8080` from a shared default. It now sets an explicit listen address on the scope controller (`127.0.0.1:18765`) and asserts it. Test: `TestStatus_ReportsListenAddr`. - L3 (telemetry review): `TestRunTelemetryStatus_ReportsEnvOverride` clears `MCPPROXY_OUTPUT` so an ambient value cannot change the output format under test. - L4 (e2e cleanup review): `scripts/test-api-e2e.sh` replaces BSD-only `sed -i ''` with a portable write-and-move, so it also runs with GNU sed. - L5 (e2e cleanup review): `scripts/test-api-e2e-cleanup-check.sh` sources the shared `scripts/descendant-pids.sh` helper instead of carrying its own recursive copy. ## Review status Clean. Unresolved findings: []. Refs #1466 Refs #1388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds abort mode (
--abortflag) to test-api-e2e-cleanup-check.sh for graceful SIGTERM handling during mid-run interruption. The script now detects the SIGTERM signal, terminates active test processes cleanly, and exits with a consistent status code. This enables CI/cleanup scripts to interrupt long-running test suites reliably.Changes
--abortflag to enable abort mode for graceful shutdownOpen Findings
Two low-priority findings deferred for future work:
glm:1.1 (low): The
--abortmode uses an ephemeral LISTEN_PORT, which forces BSD-onlysed -i ''at line 724 of test-api-e2e.sh. On GNU/Linux, this fails silently (noset -e), causing the server to bind :8081 while BASE_URL targets the ephemeral port. The suite exits early reporting false FAIL. Status: low-deferred. Rationale: Script targets local macOS runs;--abortnot wired into CI/Makefile; sed line is pre-existing.glm:1.2 (low): The
--abortmode adds a private recursivedescendants()pgrep walk instead of sourcing the existingscripts/descendant-pids.sh(withdescendant_pidsfunction), which is already sourced at line 63 and has its own unit test. The copy is untested and can diverge. Status: low-deferred. Rationale: Duplication is isolated to abort mode; the main path uses the shared helper.Closes #1388