Skip to content

test(server,supervisor): close profile v3 test gaps and deflake attribution waits - #1515

Merged
Dumbris merged 2 commits into
mainfrom
fix/issues-b6-tests
Oct 5, 2026
Merged

Dumbris merged 2 commits into
mainfrom
fix/issues-b6-tests

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026

Copy link
Copy Markdown
Member

Test-only follow-ups closing the remaining profile v3 test gaps and deflaking attribution waits.

  • 1431-1: TestRefusalPrecedence P1 now asserts denyReasons == ["token_scope"] between the two calls.
  • 1431-2: set_profile matrix row 17 asserts the stored selection survives a refusal.
  • 1445-1: guardedOps gains a create case targeting the anonymous profile's switchable_to name.
  • 1445-2: TestProfilesTool_MutationResultEqualsRESTData compares the profiles MCP tool result with REST data for create/update/delete/rename/classify/assign.
  • 1465-1: all activity-attribution waits use a shared 60s attributionWait.
  • 1451-17: supervisor TestReconcileQuiescent waits for startupReconciled and asserts the in-flight counter deterministically.

No production code changed.

Review Status

zcode (GLM-5.3) FULL review: clean (no findings), round 1.

Closes #1431
Closes #1445
Refs #1465
Refs #1451

…bution waits

Closes #1431
Closes #1445

- refusal precedence: assert the dangling-pin deny reason (token_scope)
- set_profile matrix row 17: assert the refused switch keeps the stored selection
- profiles guard coverage: add a create case for the anonymous switchable_to name
- profiles tool: compare create/update/delete/rename/classify/assign results with REST data
- activity attribution: one 60s wait const for all Eventually waits (refs #1465)
- supervisor: wait for startupReconciled so the in-flight counter is tested alone (refs #1451)
@Dumbris
Dumbris enabled auto-merge (squash) October 5, 2026 13:41
@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: c2b9eab
Status: ✅  Deploy successful!
Preview URL: https://fee35a1c.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-b6-tests.mcpproxy-docs.pages.dev

View logs

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Dumbris
Dumbris merged commit f2e58df into main Oct 5, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Follow-ups from Spec 108-h MCP profiles tool review (#1443) Follow-ups from Spec 108-bd enforcement test gaps review (#1429)

2 participants