Repository navigation
fix(web): clients presence, upgrade done step, explainer scope and import names - #1516
Merged
Merged
Conversation
…port names - clients store: the 30s presence poll owns last_seen/active_sessions; a change drops stale detail presence fields and reloads the detail (#1451) - UpgradeAdminKeyDialog: partial failure states what worked/failed, withholds the rotate panel and offers Try again; rotate only when next_step is set (#1446) - AccessExplainer: fix routes go through the scope link map except move_client (#1446) - ImportServers: emit only the names the core actually imported (#1506)
Deploying mcpproxy-docs with
|
| Latest commit: |
078b2df
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://22c01826.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w2b4-frontend-sto.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37350210193 --repo smart-mcp-proxy/mcpproxy-go
|
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Frontend fixes for the Clients presence store, the admin-key upgrade dialog, the access explainer fix routes and the import completion event.
frontend/src/stores/clients.tslets the poll own presence; a change drops stale detail presence fields and reloads the detail. Test:clients-store-presence.spec.ts.useScopeQuery.tsclientDetail route clears the filter conditionally. Test:client-binding-controls.spec.ts.UpgradeAdminKeyDialog.vuepartial failure states what succeeded and failed, withholds the rotate panel and offers Try again; rotate only when next_step is set. Test:client-binding-controls.spec.ts.AccessExplainer.vueroutes go through the scope link map. Test:access-explainer.spec.ts.ImportServers.vueemits only the names the core actually imported. Test:import-servers-completion.spec.ts.docs/features/connect-clients.mdwording.Skipped: none of the assigned items for this batch. Other wave-2 items (1435-5, 1466-8, 1466-24, 1465-4) are in other batches.
Review Status
Clean after 1 round(s). Unresolved findings: glm:1.1 (low, low-deferred) - a stale loadDetail response can overwrite a newer poll result and re-mark the row detail-loaded, regressing last_seen/active_sessions for up to one poll cycle; the unguarded
void loadDetail(id)fired by refreshPresence has no staleness check.Refs #1446
Refs #1451
Refs #1466