Repository navigation
fix(server): stop the roots fetch for a closed session and interleave FR-011 latency arms - #1517
Merged
Merged
Conversation
… FR-011 latency arms The workspace roots retry loop treated a soft-closed session (kept for closedSessionTTL) as still present, so a disconnect mid-fetch kept calling RequestRoots for the remaining attempts. Extract the loop into fetchRootsWithRetry and treat closed as gone. Sample the scoped/admin and legacy/v3 latency arms interleaved (measureInterleaved, alternating order) so a runner noise burst cannot land on one arm alone. Budget, p95 and the advisory gate are unchanged. Refs #1465, #1387
…nd-internal-server-worksp
Dumbris
enabled auto-merge (squash)
October 5, 2026 17:45
Deploying mcpproxy-docs with
|
| Latest commit: |
5d77785
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://5b3bc409.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w2b3-backend-inte.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stops the workspace roots fetch from continuing after its session has closed, and makes the FR-011 scope-latency measurement less sensitive to runner noise.
Items
internal/server/workspace.go): the retry loop treated a soft-closed session (kept forclosedSessionTTL) as still present, so a disconnect mid-fetch kept callingRequestRootsfor the remaining attempts. The loop is nowfetchRootsWithRetryand treats a closed session as gone. Test:internal/server/workspace_test.go.measureInterleavedwith alternating order. Budget, p95 and the advisorycontinue-on-errorgate are unchanged. Tests:internal/server/scope_latency_test.go,internal/server/scope_latency_profile_v3_test.go.Skipped
None.
Review Status
clean after 1 round(s), unresolved findings: []
Refs #1465
Refs #1387