Skip to content

fix(macos): clientDetail route filter, connect binding fallback and listen re-adoption - #1520

Merged
Dumbris merged 2 commits into
mainfrom
fix/issues-w2b5-macos-tray-clientsview-swift-c
Oct 6, 2026
Merged

Dumbris merged 2 commits into
mainfrom
fix/issues-w2b5-macos-tray-clientsview-swift-c

Conversation

@Dumbris

@Dumbris Dumbris commented Oct 5, 2026

Copy link
Copy Markdown
Member

Fixes three macOS tray defects found in review of earlier wave PRs.

  • 1451-4 (clientDetail route vs clients filter): approved decision applied. The route clears the active clients filter only when that filter would hide the target client. Test: ClientsRoutingTests.
  • 1449 (connect sheet binding fallback): when the selected profile has vanished, bindingTouched is reset so the write keeps the existing binding. Test: ConnectClientModelTests.
  • 1466 (Settings Listen): discarding a cleared Listen field re-adopts the running address. Test: SettingsEffectiveStateTests.

Skipped: none of the items assigned to this batch; the other approved decisions live in other batches.

Review Status

clean after 1 round(s), unresolved findings: []

Refs #1451
Refs #1449
Refs #1466

…isten re-adoption

- clientDetail route clears the clients filter only when it would hide the target (refs #1451)
- connect sheet: a vanished profile resets bindingTouched so the write keeps the existing binding (refs #1449)
- settings: discarding a cleared Listen re-adopts the running address (refs #1466)
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 5, 2026 •

Copy link
Copy Markdown

Deploying mcpproxy-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ac8cec2
Status: ✅  Deploy successful!
Preview URL: https://4cc87ee4.mcpproxy-docs.pages.dev
Branch Preview URL: https://fix-issues-w2b5-macos-tray-c.mcpproxy-docs.pages.dev

View logs

@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

📦 Build Artifacts

Workflow Run: View Run
Branch: fix/issues-w2b5-macos-tray-clientsview-swift-c

Available Artifacts

  • archive-darwin-amd64 (31 MB)
  • archive-darwin-arm64 (28 MB)
  • archive-linux-amd64 (19 MB)
  • archive-linux-arm64 (17 MB)
  • archive-windows-amd64 (31 MB)
  • archive-windows-arm64 (27 MB)
  • frontend-dist-pr (0 MB)
  • installer-dmg-darwin-amd64 (27 MB)
  • installer-dmg-darwin-arm64 (24 MB)
  • smart-mcp-proxymcpproxy-goBPF7BQ.dockerbuild (0 MB)

How to Download

Option 1: GitHub Web UI (easiest)

  1. Go to the workflow run page linked above
  2. Scroll to the bottom "Artifacts" section
  3. Click on the artifact you want to download

Option 2: GitHub CLI

gh run download 37352470700 --repo smart-mcp-proxy/mcpproxy-go

Note: Artifacts expire in 14 days.

@Dumbris
Dumbris merged commit bedbe4b into main Oct 6, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants