Repository navigation
fix(jsruntime): record block_reason profile_server_scope on nested server-scope refusals - #1524
Merged
Merged
Conversation
…rver-scope refusals A nested call_tool in code_execution to a server outside the caller's profile scope now writes block_reason=profile_server_scope on its child tool_call record. The refusal text is unchanged (non-disclosing); a legacy token refused only by its own server list keeps an empty reason. Adds the enum value to internal/profile contract + enums.json golden, regenerates TS consts, maps it to the 'open profile' action in the Web UI, and updates docs and the Spec 108 data model/refusals. Refs #1466
…le_server_scope Refs #1466
…n a profile is active
…nd-internal-jsruntime-int
Dumbris
enabled auto-merge (squash)
October 5, 2026 18:36
Deploying mcpproxy-docs with
|
| Latest commit: |
8d38b65
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4ebc6e97.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w2b2-backend-inte.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nested server-scope refusals raised from the JS runtime (code_execution calling a server outside the active profile) now record
block_reason: profile_server_scopeinstead of an untyped/generic reason. The label is only applied when a profile is actually active (follow-up commit c3c30ce).Approved decision
Decision 1466-24 (verbatim): add the typed enum value
profile_server_scope.terminology.goand the parity matrices do not enumerateblock_reason, so the Spec 108 contract is the enum home for the new value.Tests
internal/jsruntimeunit tests for the new reason, including the no-active-profile case.internal/servertests updated: nested server-outside-profile refusal now recordsprofile_server_scope(refusal precedence and set_profile v3 tests).go build ./...andgo test ./internal/jsruntime/...pass after merging origin/main.Review status
Cross-model review clean; unresolved findings: [].
Refs #1466