fix(test): repair main E2E and shuffle failures after the issue-cleanup merge train - #1526
Merged
Merged
Conversation
…ts, token scan) - search_servers_all_sources_test: drop the unused 'slow' httptest server whose handler blocks until client cancel; a stray dial made its Close() hang to the 20m package timeout. - preflight_glue_test: register the instrumented 'gh' upstream disabled so the manager's async connect cannot bump the zero-hit counter under load. - manager_oauth_test: retry the expire+scan step until it redials; a scan skips a Connecting client by design and the prior leg's reconnect may still be in flight.
Dumbris
enabled auto-merge (squash)
October 6, 2026 05:13
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37417474486 --repo smart-mcp-proxy/mcpproxy-go
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deflakes three test failures seen on main CI after the issue-cleanup merge train. Test-only changes; no production code touched.
search_servers_all_sources_testslowhttptest server whose handler blocks until the client cancels; a stray dial made itsClose()hang to the 20m package timeout.preflight_glue_testghupstream was registered enabled, so the manager's async connect could bump the zero-hit counter under load.manager_oauth_testIntroducing PRs: the flakes surfaced during the cleanup merge train; I did not bisect to individual PRs.
Proof
After merging current origin/main (#1521):
go test -race -count=3 -run 'Preflight|SearchServersAllSources' ./internal/server/passesgo test -race -count=3 -run OAuth ./internal/upstream/passesgo test ./internal/registries/passes,go build ./...cleanNo seed-based shuffle replay was run for this PR.
Review status
Clean; test-only diff.