Repository navigation
fix(macos): disambiguate reassign picker and make ServersView routing testable - #1530
Merged
Merged
Conversation
… testable Delete-reassign picker uses pickerTitle against the full profile list. Extract ServersRouteReducer, drop the duplicate onReceive observers on serverListView (handlers fired twice), add reducer + once-only tests. ViewInspector rejected (no new dependencies): tests cover the routing logic, not the SwiftUI binding. Refs #1449, closes #1392
Deploying mcpproxy-docs with
|
| Latest commit: |
c38834d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://16a8afcf.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w5b6-native-macos.mcpproxy-docs.pages.dev |
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37445279193 --repo smart-mcp-proxy/mcpproxy-go
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two macOS tray fixes in the Swift views: the profile delete-reassign picker is now unambiguous, and ServersView routing is extracted into a testable reducer with the duplicated observers removed.
Items
pickerTitleagainst the full profile list (ProfileEditorModel.swift,ProfileSheets.swift). Test: added case inProfileEditorModelTests.swift.onReceiveobservers onserverListViewmade handlers fire twice, and the routing logic could not be unit tested. Change: extractedServersRouteReducerand dropped the duplicate observers (ServersView.swift). Test: newServersViewRoutingTests.swiftcovers the reducer and once-only handling.Skipped
Design choice
Option taken: extract the routing into a pure reducer and test that, rather than adding ViewInspector to test the SwiftUI view directly. Trade-off: no new dependency and fast deterministic tests, but the SwiftUI binding itself is not exercised. This awaits maintainer review.
Review Status
Clean after 1 round(s), unresolved findings [].
Closes #1392
Refs #1449