Repository navigation
Conversation
#1522) The upstream_servers list (and the legacy Server.GetAllServers tray path) built a HealthCalculatorInput without OAuthStatus, so a server with a valid stored token read as 'Authentication required'. Extract the token-state derivation from Runtime.GetAllServers into Runtime.OAuthHealthState and use it on all three surfaces.
Dumbris
enabled auto-merge (squash)
October 6, 2026 09:51
Deploying mcpproxy-docs with
|
| Latest commit: |
94cecfd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://589c671c.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w5b1-internal-ser.mcpproxy-docs.pages.dev |
Dumbris
disabled auto-merge
October 6, 2026 13:32
Member
Author
|
Closing in favour of @neylwalecki's #1525, which fixed #1522 first with the same canonical-health approach and thorough tests (merged). Thanks @neylwalecki! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The MCP
upstream_servers listoperation reported OAuth servers without token state in their health, so a server needing sign-in or with an expired token looked healthy over MCP while REST and the CLI showed the real state. This change makes the MCP list use the same OAuth health calculation as the other surfaces.Items
internal/runtime/oauth_health.go(shared byruntime.go), and wired it into the MCP list ininternal/server/mcp.goandinternal/server/server.go.internal/server/list_upstreams_oauth_health_test.go.Skipped items
None.
Review Status
clean after 1 round(s), unresolved findings []
Closes #1522