Repository navigation
feat(index): match underscore-delimited tool-name segments in search - #1535
Merged
Merged
Conversation
…ueries A bare query such as "issue" never matched create_issue because tool_name is keyword-analyzed. Add a bare-segment wildcard clause (3+ alphanumeric chars) under the same adaptive rule as the underscore enhancement: only when no exact tool-name match is already on top, so frozen exact-name scores and ranking goldens are unchanged. refs #1449
Keeps scores and frozen goldens byte-identical for queries with no segment hit; the extra Should clause would otherwise shift BM25 query normalization. refs #1449
Deploying mcpproxy-docs with
|
| Latest commit: |
924ab8b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://48f8914b.mcpproxy-docs.pages.dev |
| Branch Preview URL: | https://fix-issues-w5b7-internal-ind.mcpproxy-docs.pages.dev |
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
📦 Build ArtifactsWorkflow Run: View Run Available Artifacts
How to DownloadOption 1: GitHub Web UI (easiest)
Option 2: GitHub CLI gh run download 37451880551 --repo smart-mcp-proxy/mcpproxy-go
|
Dumbris
enabled auto-merge (squash)
October 6, 2026 17:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bare search queries such as
issuenever matched tools likegithub:create_issue, becausetool_nameis keyword-analyzed and only prefix/exact clauses applied. This adds matching on underscore-delimited tool-name segments.Items
tool_namefield has no segment tokens, so a bare word that is a middle or trailing segment of a snake_case name produced no hit.Skipped items
None.
Design choice
Option taken: a wildcard Should clause on
tool_namefor bare segments, boosted below the prefix clause (bare segment 1.5 vs prefix 3.0), applied only when no exact match leads. The alternative was changing the analyzer to tokenize on underscores, which would require a full reindex and shift every frozen score and golden. Trade-off: the boost ratio is a heuristic. Both clauses score per term with BM25 idf, so a rare segment-only hit can outrank a common prefix hit. This awaits maintainer review.Review Status
Clean after 1 round. Unresolved findings: glm:1.1 (low, deferred). The "existing top results keep order" invariant rests only on the boost ratio, for the reason given under Design choice.
Refs #1449