Repository navigation
build(macos): require macOS 10.15 so whisper.cpp builds - #537
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
6 tasks
There was a problem hiding this comment.
Review
Verdict: approved
Review level: normal
Blocking
- none
Non-blocking
- CI was still pending (macOS/Ubuntu/Windows/browser jobs) at review time; the macOS build is the real proof of the fix and the merge should wait for it to be green.
Security checks
- Config/docs only; no filter, risk, redaction or credential paths touched. No vendor changes.
- All acceptance criteria verified in the diff: minimumSystemVersion 10.15, MACOSX_DEPLOYMENT_TARGET with comment and GGML_NATIVE kept, README (German kept) and README_DEV, entry in CHANGELOG [0.7.0] Changed, no changelog.d fragment. Spec impact none is correct.
There was a problem hiding this comment.
Review
Verdict: approved
Review level: normal
Blocking
- none
Non-blocking
- CI (macOS/Ubuntu/Windows tests, browser tests) was still running at review time; merge only when green. The macOS job is the real proof of the build fix.
Security checks
- Config, docs and changelog only; no security-critical paths touched. No public-boundary issues. Spec impact none is correct.
Previous findings
- Head unchanged since the earlier approval (6be7b0a); no open findings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #536
Summary
Sets macOS 10.15 as explicit minimum:
bundle.macOS.minimumSystemVersion,MACOSX_DEPLOYMENT_TARGETin.cargo/config.toml[env](GGML_NATIVE stays), README, README_DEV, CHANGELOG[0.7.0]Changed.Acceptance Criteria
Tests
Config/docs only; JSON validity checked.
Assumptions
None.
Spec: none (no spec lists OS versions)
Manual test steps
On macOS:
cargo build --release --target aarch64-apple-darwin -p <speech crate>; check CMakeCache for CMAKE_OSX_DEPLOYMENT_TARGET=10.15.🤖 Generated with Claude Code