Skip to content

build(macos): require macOS 10.15 so whisper.cpp builds - #537

Merged
brokoskokoli merged 1 commit into
release/0.7.0from
issue-536-macos-min
Oct 15, 2026
Merged

brokoskokoli merged 1 commit into
release/0.7.0from
issue-536-macos-min

Conversation

@smart-ssh-coder

Copy link
Copy Markdown
Contributor

Closes #536

Summary

Sets macOS 10.15 as explicit minimum: bundle.macOS.minimumSystemVersion, MACOSX_DEPLOYMENT_TARGET in .cargo/config.toml [env] (GGML_NATIVE stays), README, README_DEV, CHANGELOG [0.7.0] Changed.

Acceptance Criteria

  • tauri.conf.json / config.toml values: verified by inspection (no macOS available here; build not run).
  • README, CHANGELOG: done; no changelog.d fragment.
  • CI: see checks.

Tests

Config/docs only; JSON validity checked.

Assumptions

None.

Spec: none (no spec lists OS versions)

Manual test steps

On macOS: cargo build --release --target aarch64-apple-darwin -p <speech crate>; check CMakeCache for CMAKE_OSX_DEPLOYMENT_TARGET=10.15.

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

@smart-ssh-reviewer smart-ssh-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Verdict: approved
Review level: normal

Blocking

  • none

Non-blocking

  • CI was still pending (macOS/Ubuntu/Windows/browser jobs) at review time; the macOS build is the real proof of the fix and the merge should wait for it to be green.

Security checks

  • Config/docs only; no filter, risk, redaction or credential paths touched. No vendor changes.
  • All acceptance criteria verified in the diff: minimumSystemVersion 10.15, MACOSX_DEPLOYMENT_TARGET with comment and GGML_NATIVE kept, README (German kept) and README_DEV, entry in CHANGELOG [0.7.0] Changed, no changelog.d fragment. Spec impact none is correct.

@smart-ssh-reviewer smart-ssh-reviewer Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review

Verdict: approved
Review level: normal

Blocking

  • none

Non-blocking

  • CI (macOS/Ubuntu/Windows tests, browser tests) was still running at review time; merge only when green. The macOS job is the real proof of the build fix.

Security checks

  • Config, docs and changelog only; no security-critical paths touched. No public-boundary issues. Spec impact none is correct.

Previous findings

  • Head unchanged since the earlier approval (6be7b0a); no open findings.

@brokoskokoli
brokoskokoli merged commit 8530583 into release/0.7.0 Oct 15, 2026
7 checks passed
@brokoskokoli
brokoskokoli deleted the issue-536-macos-min branch October 15, 2026 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant