Repository navigation
Billing: Set compute duration on execution result - #2464
Merged
Merged
Conversation
Contributor
📊 API Diff Results
|
This was referenced Oct 13, 2026
DylanTinianov
force-pushed
the
CRE-6779-module-execute-result
branch
from
October 13, 2026 21:14
f995c27 to
eff4aa5
Compare
DylanTinianov
changed the title
DylanTinianov
force-pushed
the
CRE-6779-module-execute-result
branch
3 times, most recently
from
October 14, 2026 14:35
15cb0c3 to
2d29eb8
Compare
DylanTinianov
changed the title
DylanTinianov
changed the base branch from
CRE-6920-confidential-execution-duration
to
main
October 14, 2026 14:39
…(CRE-6779) The engine meters it as compute. Confidential runs get the same field set inside the enclave, which executes workflows with this host. Bump chainlink-protos/cre/go to 94b3b3de (#473). Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
DylanTinianov
force-pushed
the
CRE-6779-module-execute-result
branch
from
October 14, 2026 14:44
2d29eb8 to
02b03ce
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Pre-hook duration is discarded, causing compute metering to under-report affected executions.
1 open finding
What changed in this PR
Adds WASM execution duration reporting for downstream compute metering.
Changes:
- Measures
runWasmwall-clock duration. - Sets
ExecutionResult.compute_duration_ms. - Updates protobuf dependencies and verifies field presence.
| File | Description |
|---|---|
pkg/workflows/wasm/host/module.go |
Records execution duration. |
pkg/workflows/wasm/host/standard_test.go |
Verifies duration presence. |
go.mod |
Updates CRE protobuf dependency. |
go.sum |
Updates dependency checksums. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
DylanTinianov
changed the title
cedric-cordenier
previously approved these changes
Oct 14, 2026
DylanTinianov
force-pushed
the
CRE-6779-module-execute-result
branch
from
October 14, 2026 15:32
d3ec3d0 to
3d03841
Compare
DylanTinianov
enabled auto-merge
October 14, 2026 15:40
ilija42
approved these changes
Oct 14, 2026
nolag
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The WASM host sets
ExecutionResult.compute_duration_ms(chainlink-protos#472 / #473) to the guest run's wall-clock aroundrunWasm. No interface change.Why
Compute metering (CRE-6779, chainlink#23858) meters what the module that ran the workflow reports. The confidential enclave executes workflows with this same host, so a confidential run gets the field set inside the enclave and it travels back to the node inside
SdkExecutionResult— one code path for both.Notes
runWasmreturns no result; the engine then falls back to its wall-clock.main; pins protos94b3b3de(Add validator usage to ondemand trigger #473's head) until it merges. confidentialworkflow: regenerate client with execution_duration_ms #2457 is no longer needed.