Repository navigation
cresettings: add ShardingFailoverEnabled gate - #2468
Merged
Merged
Conversation
chainlink core builds this gate ad hoc (settings.Bool(false) with Key "ShardingFailoverEnabled", global scope), so it cannot be overridden via CRE settings files: chainlink-deployments rejects it as an unknown field. Add it to the Schema so environments can enable it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The small, additive schema change has consistent defaults and documentation, with no blocking issues identified.
0 open findings
What changed in this PR
Registers ShardingFailoverEnabled in the CRE settings schema so environment settings validation recognizes the gate, while preserving its disabled default.
Changes:
- Adds the boolean setting with default
false. - Updates serialized defaults and the settings flowchart.
| File | Description |
|---|---|
pkg/settings/cresettings/settings.go |
Adds and documents the gate. |
pkg/settings/cresettings/README.md |
Includes the gate in the flowchart. |
pkg/settings/cresettings/defaults.toml |
Records the disabled default. |
pkg/settings/cresettings/defaults.json |
Records the disabled default. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
✅ API Diff Results -
|
bolekk
approved these changes
Oct 14, 2026
amit-momin
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
ShardingFailoverEnabled(global,Bool(false)) tocresettings.Schema.chainlink core currently builds this gate ad hoc in
core/services/workflows/v2/config.go:Because the key isn't in the Schema, chainlink-deployments' settings verification rejects it as an unknown field, so it can't be enabled per environment (needed to turn it on in staging zone-b).
When enabled, a sharded workflow DON caches trigger events for workflows owned by another shard instead of denying them (
ShardFailoverManager,DenyNotOwnerpath), so it can take over if the owning shard fails.Changes
settings.go: new field + defaultfalsedefaults.toml/defaults.json: regenerated (go test . -update)README.md: added to thesyncer.tryEngineCreateflowchart subgraphKey, scope and default match the existing core definition, so behavior is unchanged. A follow-up in chainlink core can switch to
cresettings.Default.ShardingFailoverEnabled.🤖 Generated with Claude Code