Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused refactors preserve existing behavior, with no unresolved findings.
0 open findings
What changed in this PR
Cleans up CLI profile handling following the profiles feature introduced in #2456.
Changes:
- Replaces pairwise case-collision checks with canonical Unicode folding and map lookups.
- Introduces separate iterators for profile maps and values.
- Narrows panic recovery to selector callbacks and simplifies scope checks.
| File | Description |
|---|---|
x/config/cli/profile.go |
Refactors profile validation, traversal, and selector handling. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
📊 API Diff Results
|
nolag
marked this pull request as ready for review
October 14, 2026 20:25
nolag
enabled auto-merge
October 14, 2026 20:25
jmank88
approved these changes
Oct 14, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from PR comments I read after merging