Fail fast when CL_DATABASE_URL is unset in test helpers - #555
Merged
Merged
Conversation
product-security-plaid-production
Bot
requested a review
from russell-stern
September 14, 2026 14:46
Contributor
📊 API Diff Results
|
pavel-raykov
approved these changes
Sep 14, 2026
cll-gg
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewSqlxDB reported the missing env var with t.Errorf and then returned a nil
*sqlx.DB. Errorfis log + Fail, which marks the test failed but keeps it running, so the caller's first query dereferenced nil and the run died as:The actual explanation was scrolled off above the stack trace, so a missing local Postgres looked like a crash in sqlx. Use
require.NotEmpty, which halts via FailNow and reports the calling