OEV-1803 Remove Meter() TODO post core bump - #557
Open
mostlyconsistent wants to merge 1 commit into
Open
mostlyconsistent wants to merge 1 commit into
mostlyconsistent wants to merge 1 commit into
Conversation
Contributor
|
👋 mostlyconsistent, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
📊 API Diff Results
|
jmank88
reviewed
Sep 15, 2026
Comment on lines
+187
to
+189
| if o.Meter == nil { | ||
| err = errors.Join(err, errors.New("nil Meter")) | ||
| } |
Collaborator
There was a problem hiding this comment.
It might be better to wait a bit before making this strictly required, since there is still a chance that we need to patch an older release with a newer chainlink-evm.
cll-gg
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
legacyevm.ChainOpts.Meterrequired and drops thebeholder.GetMeter()fallback innewChainThe fallback was a temporary bridge added with
evm_chain_config_info(#548): chainlink core did not pass a meter, so chains silently fell back to the global beholder meter. smartcontractkit/chainlink#23726 has landed and core now wiresMeter: beholder.GetMeter()explicitly inapplication.go, so the TODO can go and the dependency becomes explicit rather than implicit global state.