Fix a pointer comparison for Chain SetFrom - #558
Merged
Merged
Conversation
Contributor
|
👋 nolag, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
product-security-plaid-production
Bot
requested a review
from patrickhuie19
September 15, 2026 18:13
nolag
enabled auto-merge (squash)
September 15, 2026 18:14
Contributor
📊 API Diff Results
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review comments remain, and the changes include comprehensive test coverage.
Pull request overview
Fixes Chain.SetFrom to match key-specific configurations by address value instead of pointer identity.
Changes:
- Adds nil-safe address comparison.
- Adds merge, append, and override coverage.
File summaries
| File | Description |
|---|---|
pkg/config/toml/defaults.go |
Corrects key-specific matching logic. |
pkg/config/toml/defaults_test.go |
Adds coverage for Chain.SetFrom behavior. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jmank88
approved these changes
Sep 15, 2026
pkcll
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.