Skip to content

cre/sdk: drop the compute_duration_ms field comment #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DylanTinianov wants to merge 1 commit into from
Closed

cre/sdk: drop the compute_duration_ms field comment #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions cre/go/installer/pkg/embedded_gen.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 2 additions & 8 deletions cre/go/sdk/sdk.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 0 additions & 6 deletions cre/sdk/v1alpha/sdk.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,12 +146,6 @@ message ExecutionResult {
TriggerSubscriptionRequest trigger_subscriptions = 3;
Restrictions restrictions = 4;
}
// compute_duration_ms is the wall-clock duration of the workflow run in
// milliseconds, as measured by the module that executed it: the guest run
// for the WASM host, the enclave-reported duration for confidential
// workflows. The host sets it after the run and the engine meters it as
// compute (cre:workflow:compute). Presence distinguishes an unavailable
// measurement from a measured zero.
optional int64 compute_duration_ms = 5;
}

Expand Down
Loading