Repository navigation
Remove no-lockbox LockReleaseTokenPool in favour of the lockbox variant - #888
Merged
Merged
Conversation
krebernisak
force-pushed
the
feat/tp-lockbox-only
branch
from
September 15, 2026 17:03
59894a3 to
6c52ec8
Compare
duck-types
previously approved these changes
Sep 21, 2026
krebernisak
dismissed
duck-types’s stale review
September 22, 2026 20:35
The base branch was changed.
krebernisak
force-pushed
the
feat/tp-lockbox-only
branch
from
September 23, 2026 10:02
6c52ec8 to
26e2714
Compare
vicentevieytes
previously approved these changes
Sep 23, 2026
krebernisak
force-pushed
the
feat/tp-lockbox-only
branch
from
September 24, 2026 12:23
b58bd71 to
c8c861d
Compare
duck-types
previously approved these changes
Sep 24, 2026
The standalone lock_release pool duplicated the lock/release semantics of LockReleaseLockboxTokenPool with a weaker custody model: liquidity and fees held in the pool's own jetton wallet behind an `accruedFees` ledger, which pins custody to a pool that cannot be upgraded. The lockbox variant matches EVM's LockReleaseTokenPool + ERC20LockBox split, so it is the one we ship. Deployment now derives the pool address from its final storage, deploys the JettonLockBox first, and grants OPERATOR_ROLE to the precomputed pool address before deploying the pool. JettonLockBox is registered in pkg/bindings so the deployment pipeline can resolve it. Test harnesses gain a shared lockbox helper; liquidity is minted to the lockbox rather than the pool.
krebernisak
force-pushed
the
feat/tp-lockbox-only
branch
from
September 28, 2026 09:56
c8c861d to
f2de5db
Compare
krebernisak
enabled auto-merge (squash)
September 28, 2026 17:43
duck-types
approved these changes
Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the no-lockbox
LockReleaseTokenPoolsoLockReleaseLockboxTokenPoolis the only lock/release variant.
The deleted variant duplicated the same lock/release semantics with a weaker
custody model — liquidity and fees held in the pool's own jetton wallet behind
an
accruedFeesledger. That pins custody to a contract that cannot beupgraded without migrating balances.
lock_release_lockbox+JettonLockBoxseparates long-lived custody from upgradable pool logic, matching EVM's
LockReleaseTokenPool+ERC20LockBoxsplit, which is the parity target.Changes
contracts/ccip/pools/lock_release/**, its compilescript, generated wrapper, and dedicated spec. Update registries
(
Acton.toml,wrappers/gen/index.ts,generateContractsPkg.ts).pkg/ccip/bindings/tokenpool/lockrelease. RegisterLockReleaseLockboxTokenPoolandJettonLockBoxinpkg/bindings/index.go(the latter was previously unregistered despite the bindings existing).
DeployTokenPoolForTokenretargeted to the lockbox variant.The pool stores the lockbox address, so the lockbox is deployed first; the
pool address is derived from its final storage and granted
OPERATOR_ROLEbefore the pool itself is deployed.
testadapterfunds the lockbox walletinstead of the pool wallet.
tests/ccip/helpers/lockbox.ts; the OffRamp and e2eharnesses are repointed to the lockbox pool.
kept with a removal note rather than rewritten.
Reviewer notes
deployment/ccip/1_6_0/sequences/tokens.gois the only file with newproduction logic. Two non-obvious ordering constraints live there: the lockbox
is built before the pool because the pool stores its address, and the
OPERATOR_ROLEgrant must follow init becauseonInitrebuilds the RBAC data.