Fix: feequoter bindings - #893
Merged
Merged
Conversation
duck-types
changed the base branch from
followup/fix/exec-report-offchainTokenData
to
main
September 17, 2026 12:35
duck-types
force-pushed
the
fix/tooling/feequoter-bindings
branch
from
September 17, 2026 12:36
50b0ba0 to
ba6db6b
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Critical issues remain with duplicate address handling and unsupported test sample generation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates FeeQuoter bindings to use typed dictionaries, support fee-token removal, register the operation, and add serialization tests.
Changes:
- Replaces manual dictionary serialization with typed bindings.
- Registers the FeeQuoter operation.
- Adds fee-token removal and round-trip coverage.
File summaries
| File | Description |
|---|---|
deployment/pkg/ops/ton/send_test.go |
Updates unsupported opcode coverage. |
deployment/pkg/ops/index.go |
Registers the FeeQuoter operation. |
deployment/ccip/operation/fee_quoter.go |
Builds typed add/remove fee-token payloads. |
cciplib/ccip/bindings/feequoter/fee_quoter.go |
Uses typed dictionary bindings. |
cciplib/ccip/bindings/feequoter/fee_quoter_test.go |
Adds serialization round-trip tests. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
krebernisak
previously approved these changes
Sep 17, 2026
| } | ||
|
|
||
| // UpdateFeeQuoterPricesOp operation to update FeeQuoter prices | ||
| // UpdateFeeQuoterFeeTokensOp operation to update FeeQuoter fee tokens |
Collaborator
There was a problem hiding this comment.
Think this custom op is not doing much on top of just sending a message, and now that we can serialize inputs can probably just be replaced with a call to ton/ops/send-message op with body.
duck-types
force-pushed
the
fix/tooling/feequoter-bindings
branch
from
September 17, 2026 13:33
ce9ef3f to
d0b10bb
Compare
app-token-issuer-integrations
Bot
added
the
nix-tidy-skip
duck-types
enabled auto-merge (squash)
September 17, 2026 14:17
krebernisak
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.