Skip to content

fix: the on-chain rung reports its gap instead of returning silently without a fork - #35

Merged
SyedAsadKazmi merged 2 commits into
mainfrom
fix/onchain-rung-silent-skip
Sep 15, 2026
Merged

SyedAsadKazmi merged 2 commits into
mainfrom
fix/onchain-rung-silent-skip

Conversation

@aelmanaa

Copy link
Copy Markdown
Contributor

This pull request improves the robustness and test coverage of the on-chain code verification logic in VerifyChain. The main focus is ensuring that when an RPC (fork) is unavailable, the on-chain verification rung reports its status as a skipped/unverified gap, rather than failing silently. This change is reflected in both the contract logic and its associated tests and test scripts.

On-chain code verification robustness:

  • The _checkOnChainCode function now always runs, regardless of RPC status, and explicitly reports a skip with a descriptive message if no fork is present, instead of returning silently. [1] [2]

Test enhancements:

  • The test for RPC-gated rungs now includes the on-chain code rung, expecting four unverified gaps (on-chain, registry TAR, roles, and lanes) instead of three. [1] [2]
  • Added a dedicated test to ensure the on-chain rung does not exit silently without a fork and that the verdict is set to INCOMPLETE as expected.
  • Introduced a new test hook onChainNoForkVerdictForTest to facilitate this check.

Test script updates:

  • The test tooling script now includes a case to verify that the on-chain rung prints its SKIP message when run without an RPC, ensuring visibility of the unverified gap.

@aelmanaa
aelmanaa requested review from a team as code owners September 14, 2026 11:06
@github-actions

Copy link
Copy Markdown

👋 aelmanaa, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@SyedAsadKazmi
SyedAsadKazmi force-pushed the fix/onchain-rung-silent-skip branch from 2f92999 to 42a64b1 Compare September 15, 2026 03:01
@SyedAsadKazmi
SyedAsadKazmi merged commit 4fd163b into main Sep 15, 2026
15 checks passed
@SyedAsadKazmi
SyedAsadKazmi deleted the fix/onchain-rung-silent-skip branch September 15, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants