Repository navigation
fix: the on-chain rung reports its gap instead of returning silently without a fork - #35
Merged
Merged
Conversation
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
SyedAsadKazmi
force-pushed
the
fix/onchain-rung-silent-skip
branch
from
September 15, 2026 03:01
2f92999 to
42a64b1
Compare
SyedAsadKazmi
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the robustness and test coverage of the on-chain code verification logic in
VerifyChain. The main focus is ensuring that when an RPC (fork) is unavailable, the on-chain verification rung reports its status as a skipped/unverified gap, rather than failing silently. This change is reflected in both the contract logic and its associated tests and test scripts.On-chain code verification robustness:
_checkOnChainCodefunction now always runs, regardless of RPC status, and explicitly reports a skip with a descriptive message if no fork is present, instead of returning silently. [1] [2]Test enhancements:
onChainNoForkVerdictForTestto facilitate this check.Test script updates: