Repository navigation
feat: discover-tokens lists the token catalog the reviewedOnly default hides - #37
Merged
Merged
Conversation
|
👋 aelmanaa, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
SyedAsadKazmi
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a new
discover-tokensMakefile target and its supporting script, which lists the CCIP API token catalog for an operator, including local state awareness and robust handling of API filtering and paging. It also documents the relevant CCIP REST API v2 specification and improves developer guidance in related scripts. The most important changes are summarized below.New Features:
discover-tokensMakefile target and the supportingscript/config/discover-tokens.shscript, which lists the CCIP API token catalog for an operator, handles filtering via environment variables, and ensures correct API usage by explicitly setting parameters that would otherwise silently return incomplete results. [1] [2] [3]docs/primitives/catalog.jsonto include the newdiscover-tokenstarget, increasing the count of Makefile targets. [1] [2]Documentation:
docs/reference/ccip-api.md, documenting the CCIP REST API v2 spec, common pitfalls with defaulted parameters, and the exact API routes and parameters used by this repository.docs/index.md.Developer Guidance and Test Improvements:
script/config/ccip-config-source.sh,script/config/ccip-chain-meta.sh, andscript/config/sync-discover.shto guide developers to consult the spec before changing queries. [1] [2] [3]discover-tokensand ensured proper cleanup in the test tooling script. [1] [2]