Repository navigation
make: refuse the EVM-only forking targets on a non-EVM chainFamily - #38
Merged
Merged
Conversation
SyedAsadKazmi
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces robust handling for non-EVM (e.g., Solana) chains in the Makefile and related config tooling. It ensures that EVM-only deployment targets (like
deploy-tokenandadopt-token TOKEN=) now explicitly refuse to run on non-EVM chains, providing clear guidance to the user. Additionally, thetoolstarget now checks for the chain family and gives appropriate feedback, while theroles-checkscript is updated to skip non-EVM chains gracefully. Documentation and help texts are updated to reflect these changes.EVM vs Non-EVM Chain Handling:
require-evm-chainMakefile macro to prevent EVM-only targets from running on non-EVM chains, with user-friendly error messages and hints for proper usage. (Makefile) [1] [2] [3]adopt-token,deploy-token,deploy-pool,deploy-lockbox, anddeploy-lockrelease-pooltargets to invoke this macro, ensuring they only operate on EVM chains. (Makefile) [1] [2]script/config/chain-family.shto robustly determine a chain's family, defaulting toevmon missing or malformed configs to avoid accidental refusals.Tooling and Documentation Updates:
toolstarget to check the chain's family and provide clear, family-specific guidance without requiring extra tools for non-EVM chains. Updated help text and the catalog accordingly. (Makefile,docs/primitives/catalog.json) [1] [2]docs/config-schema.md) to describe the new EVM-only enforcement and clarify behavior for non-EVM chains.roles-check Script Improvements:
roles-check.shto skip non-EVM chains both when specified explicitly and during sweeps, providing clear SKIP messages and accurate summary output. (script/config/roles-check.sh) [1] [2] [3] [4]