Skip to content

feat: doctor guards silo isolation and lock-and-lock lanes - #40

Merged
aelmanaa merged 1 commit into
mainfrom
feat/silo-isolation-guard
Sep 22, 2026
Merged

aelmanaa merged 1 commit into
mainfrom
feat/silo-isolation-guard

Conversation

@aelmanaa

@aelmanaa aelmanaa commented Sep 21, 2026 •

Copy link
Copy Markdown
Contributor

This pull request introduces comprehensive improvements to the handling, detection, and documentation of liquidity bridges and siloed pools, especially regarding the risks of misconfigured lanes between chains using different lock boxes. The main changes include new checks and warnings in the verification scripts, enhanced user-facing documentation about liquidity and silo isolation, and more robust error handling for custom lock box implementations.

Verification & Detection Enhancements:

  • Added a check in VerifyChain.s.sol to detect and fail if two chains mapped to different lock boxes declare a direct lane to each other, preventing "liquidity drift" where tokens can be released from a box that never received them. This includes the new _checkSiloIsolation method and supporting utilities. [1] [2]
  • Improved warnings for legitimate lock-release bridges (where both sides are lock-release pools), clarifying when rebalancing is required and distinguishing from the unsound "two silos" case. (F5e6a668L142R142, script/config/VerifyChain.s.solR2261-R2475)
  • Enhanced error handling for custom lock box implementations that do not expose getAllAuthorizedCallers(), warning instead of failing if the contract still supports the token.

Documentation Updates:

  • Updated operational and troubleshooting docs to clearly explain the risks of direct lanes between differently-boxed chains, how to diagnose and fix liquidity drift, and the correct topologies for siloed and lock-release pools. This includes new "gotchas" and step-by-step troubleshooting advice. [1] [2] [3] [4]

General Improvements:

  • Added explicit documentation and code comments clarifying the difference between a liquidity bridge and a mint/burn mesh, and how to monitor and rebalance liquidity as needed. [1] [2]

These changes collectively make it much harder to accidentally misconfigure cross-chain liquidity, provide better diagnostics when things go wrong, and give operators clear instructions on how to maintain safe and balanced pools.

@aelmanaa
aelmanaa requested review from a team as code owners September 21, 2026 11:33
@aelmanaa
aelmanaa force-pushed the feat/silo-isolation-guard branch from 266c93c to f558f8b Compare September 21, 2026 16:34
@aelmanaa
aelmanaa force-pushed the feat/silo-isolation-guard branch from f558f8b to b199583 Compare September 21, 2026 16:49
@aelmanaa
aelmanaa merged commit 6ed0c40 into main Sep 22, 2026
15 checks passed
@aelmanaa
aelmanaa deleted the feat/silo-isolation-guard branch September 22, 2026 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants