Repository navigation
feat: doctor guards silo isolation and lock-and-lock lanes - #40
Merged
Merged
Conversation
aelmanaa
force-pushed
the
feat/silo-isolation-guard
branch
from
September 21, 2026 16:34
266c93c to
f558f8b
Compare
aelmanaa
force-pushed
the
feat/silo-isolation-guard
branch
from
September 21, 2026 16:49
f558f8b to
b199583
Compare
SyedAsadKazmi
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive improvements to the handling, detection, and documentation of liquidity bridges and siloed pools, especially regarding the risks of misconfigured lanes between chains using different lock boxes. The main changes include new checks and warnings in the verification scripts, enhanced user-facing documentation about liquidity and silo isolation, and more robust error handling for custom lock box implementations.
Verification & Detection Enhancements:
VerifyChain.s.solto detect and fail if two chains mapped to different lock boxes declare a direct lane to each other, preventing "liquidity drift" where tokens can be released from a box that never received them. This includes the new_checkSiloIsolationmethod and supporting utilities. [1] [2]getAllAuthorizedCallers(), warning instead of failing if the contract still supports the token.Documentation Updates:
General Improvements:
These changes collectively make it much harder to accidentally misconfigure cross-chain liquidity, provide better diagnostics when things go wrong, and give operators clear instructions on how to maintain safe and balanced pools.