Skip to content

feat(steering): guide steering setup and confirm missing parameters (#534) - #539

Merged
smota merged 3 commits into
developmentfrom
feat/534-steering-setup
Oct 18, 2026
Merged

smota merged 3 commits into
developmentfrom
feat/534-steering-setup

Conversation

@smota

@smota smota commented Oct 18, 2026

Copy link
Copy Markdown
Owner

Implement a guided agentflow-sdlc steer setup flow and portable steering operating agreement contract (lib/config/steering-agreement.mjs) for Goal #534.

  • Resolve existing steering settings from agent-workflow.config.json (or unified agentflow.config.json), sdlc.config.json, and the pinned executionDistribution profile (steer.lead default and fallback routes) via inspectSteeringAgreement (lib/config/steering-agreement.mjs) (AC1, AC2).
  • Reuse valid, already-confirmed steering settings when confirmedDigest matches resolved parameters (reusedConfirmedAgreement: true, questions: []), ask bounded questions when executionDistribution or goalScope is missing, and present resolved defaults (steeringOwner, returnRoute, reviewAndPublicationAuthority, quotaPolicy, checkpointsAndStopConditions) for single-digest confirmation via steer setup --plan and steer setup --apply --plan-file <file> --confirm <digest> (AC1, AC2).
  • Enforce authorityBoundary flags as const: false in schemas/agentflow-config.schema.json, validateSteeringAgreementShape, computeSteeringParametersDigest, and applySteeringAgreement, and disclose across skills/agentflow-steerer/SKILL.md, adapters/claude-code/skills/agentflow-steerer/SKILL.md, adapters/openrig/agentflow-steer/CULTURE.md, adapters/openrig/agentflow-steer/startup/context.md, and docs/steering-merge-authority.md that steer-guard blocks direct file edits and git mutations (not steer setup --apply), and that conversational confirmation / steer setup records operating preferences only and never satisfies evaluateSteeringBinding or evaluateMergeReadiness or grants merge/publication authority (AC3).

Implemented issues

Closes #534

Related issues

#516; #535

CI-equivalent validation

Status: passed
Commands: pnpm validate:release; npx vitest run lib/__tests__/steering-agreement.test.mjs scripts/__tests__/steering-help.test.mjs scripts/__tests__/steer.test.mjs.
Results: all test suites, hooks, workflow, distribution, authority, extension, skill, role, path, docs, reachability, evals, collaboration, package-parity, sandbox, cockpit, and npm-package checks passed.

Workflow evidence

Workflow-status comment: #534 (comment)
Handover comments: exception: single-session orchestration with bounded subagent delegation
Role-pass summary: Agy orchestrated architecture and implementation; Grok (xai/grok-4.7-build-fast) authored the test suite; Grok (xai/grok-4.7) executed independent cross-family Phase 6 review (APPROVE).
Validation evidence: full pnpm validate:release recorded in the workflow-status comment.

Agent review

Implemented by: agy
Launcher: antigravity
Executor: agy-session
Transport: local-cli
Delegation boundary: current-session
Model / runtime: Gemini 4 Argon (low) orchestrator; delegated builder/reviewer via pi-cli (xai/grok-4.7-build-fast and xai/grok-4.7, low)
Review: self-review
Workflow profile: standard
Merge owner: human/operator
Mode: single-agent
Self-review disclosure: Agy performed final synthesis and self-review; cross-family review was also performed by xai/grok-4.7 via pi -p (APPROVE).

Follow-up issues

None created; #535 remains tracked in the backlog.

@smota
smota merged commit d811452 into development Oct 18, 2026
7 checks passed
@smota
smota deleted the feat/534-steering-setup branch October 18, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

goal: guide steering setup and confirm missing parameters

1 participant