You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[bug] empty verify_command silently passes nodes with no deterministic evidence #56
With verify_command = [], the deterministic check is skipped without any message (crates/meshloop-engine/src/run_loop.rs:1301, if !self.verify_command.is_empty()), and the node advances to AwaitingReview as if it had passed.
ADR 0007 says deterministic checks are "always required, produced by real local tools". Today an empty command means a node has no deterministic evidence beyond the git diff, and no output says so.
Observed
Run issues-44-45 (PR #49), node 2: the worker added tests that didn't compile, because a non-Sync test double was passed into a Sync harness interface. The run config had verify_command = []. The node reached AwaitingReview. The problem surfaced only after integrating, when the origin agent ran cargo test itself.
Expected
An empty verify_command writes an evidence row kind = "verify", outcome = "skipped", not nothing.
doctor --config and run warn when verify_command is empty.
Open question for the maintainer: should an empty verify_command block run unless --allow-no-verify is passed, to match ADR 0007 strictly? Warning-only is the minimum.
Acceptance criteria
Test: empty verify_command → the attempt has a verify: skipped evidence row.
Test: doctor --config reports a warning naming verify_command.
Executors: Claude Sonnet Meshloop workers wrote the change, and the Claude Code (Opus 5.5) orchestrator made the fixes recorded in the commit messages.
Checks:cargo run --locked -p xtask -- check passes on 8808951 (Windows 11). Not run: Linux/macOS.
CI at merge: ubuntu check passed; the windows and second ubuntu jobs were still pending.
Activity
smota commentedon Oct 7, 2026
Workflow status: delivered. PR #63 merged by smota as
d058307(2026-10-07).work/status-liveness-verify), commit(s) eab9828.cargo run --locked -p xtask -- checkpasses on8808951(Windows 11). Not run: Linux/macOS.