scripts: pin the opentelemetry-proto revision used by codegen - #75
Merged
sfc-gh-vpalekar merged 1 commit intoSep 15, 2026
Merged
Conversation
sfc-gh-sying
approved these changes
Sep 14, 2026
Pin the upstream source to a full commit hash (PROTO_REPO_COMMIT) and verify the checkout resolves to exactly that commit before generating code. Collect discovered proto paths into a quoted bash array so each file is passed to protoc as a single argument, and cover the pinned checkout and path-handling behavior with unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-eukim
force-pushed
the
proto-codegen-commit-pin
branch
from
September 14, 2026 21:40
0075743 to
26a735d
Compare
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
sfc-gh-vpalekar
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine the proto code-generation setup:
(PROTO_REPO_COMMIT) instead of a branch or tag, and verify the
checkout resolves to exactly that commit before generating code.
is passed to protoc as a single argument, regardless of whitespace or
special characters in filenames.
when sourced) and cover it with unit tests.
Tests
tests/test_proto_codegen_revision_pin.py covers the pinned-checkout
behavior (tag moves, unknown commits, and tag rejection).