build: validate PATH safety in the release build scripts - #78
Merged
sfc-gh-vpalekar merged 1 commit intoSep 17, 2026
Merged
Conversation
![snowflake-security-bot[bot]](https://avatars.githubusercontent.com/u/140554735?s=60&v=4){kind=small}
sfc-gh-eukim
force-pushed
the
release-path-validation
branch
from
September 14, 2026 22:11
b3f4d93 to
1c2f982
Compare
sfc-gh-vpalekar
approved these changes
Sep 14, 2026
sfc-gh-sying
approved these changes
Sep 15, 2026
Refine the release build setup further: - add assert_secure_path to scripts/release_lib.sh, which refuses to build if any PATH directory (or its parents) is writable by other users, is missing, relative, or empty; the check runs its own commands from the base system directories - build.sh and pypi-build.sh run this check first, before any other PATH-resolved command, and resolve the repo root with shell builtins - SNOWFLAKE_TELEMETRY_ALLOW_UNSAFE_PATH=1 bypasses the check for local test builds Co-authored-by: Cursor <cursoragent@cursor.com>
sfc-gh-eukim
force-pushed
the
release-path-validation
branch
from
September 16, 2026 04:03
1c2f982 to
238ad1b
Compare
sfc-gh-vpalekar
approved these changes
Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refine the release build setup further:
build when any PATH directory (or a parent) is writable by other
users, missing, relative, or empty
PATH-resolved command, and resolve the repo root with shell builtins
bypasses the check
Operational note
The release build will stop if a PATH directory is writable by other
users until the agent's toolchain directories are tightened up.