Document identifier time to live for Identities - #1945
jamessnowplow wants to merge 2 commits into
Conversation
Docs style reviewOverall this reads well: the new page follows the directory + A few things to address: 1. No release note for a new featureThe PR documents new Console functionality (a per-identifier Time to live field, with a 180-day default). CLAUDE.md, "Release notes":
Add a 2. Overloaded paragraph in "When values are removed"
The style guide's page-structure guidance ("Introduce lists with a sentence ending in a colon", "Precede every heading and list with at least one paragraph of prose") supports breaking this up. Suggest keeping the first sentence as the lead-in and moving the behavioral rules into a list: Identities records a last-seen date for an identifier value the first time it appears in an event after its type has a TTL, and updates it on each later event. A few details affect when a value is removed:
* The last-seen date is the UTC date when the event is processed, not the event's own timestamp, so reprocessing an old event sets the date to the processing date
* The date never moves to an earlier day
* Identities records last-seen dates asynchronously and on a best-effort basis, so a sighting can occasionally be lostThe same density applies to 3. Dangling subject / passive construction
Grammatically,
Related vagueness on line 20: "A value that appears in an event before removal reaches it gets a new last-seen date and stays." → "A value that appears in an event before Identities removes it gets a new last-seen date and stays." 4. Single-digit number written as a numeral
Style guide, Grammar and spelling: "Spell out single-digit numbers as words: 'three events' not '3 events'." Suggest: "Enter a number of days between seven and 36,500" (the thousands separator also makes the upper bound readable). 5. Passive heading
CLAUDE.md, Headings: "Prefer imperative voice" and "Use active voice". Suggest Nits
|
|
Applied items 2, 3, 5, and both nits in 05b8885. Item 1: the release note will come in a later PR. Item 4: keeping the numerals. The Console validation message reads "Must be between 7 and 36500 days" and the help text renders the same digits, so the docs match the text the reader sees in the UI. |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
documentation | 05b8885 | Commit Preview URL Branch Preview URL |
Sep 16 2026, 03:20 PM |
No description provided.