Conversation
fredroy
reviewed
Sep 15, 2026
fredroy
left a comment
Contributor
There was a problem hiding this comment.
This PR is raising an issue for Regression for me ; what if the regression scene just contains a VisualModel, or an other state (if one day there will be other meaningful State?)
Maybe we should consider the broader State than the Mechanical Object
Contributor
Author
|
You are right, and this would also require a bit more info than the id of the state for the reference file. I have work on adding meta data to reference files, I think that adding the unique identifier (aka its full path in the scene) is a must have to enable using any quind of state. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no mstate is found then an error is thrown in write mode, and a failure in compare.
I did'nt touch the legacy code because it is legacy, but ideally it shouldn't allow empty mstate list neither.