Conversation
bakpaul
requested review from
epernod and
fredroy
and removed request for
epernod
September 18, 2026 15:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the topology-based regression test to the scripts. Only last commit was AI-generated. The CLAUDE.md file used is copy/pasted at the end of this description minus the part regarding environment handling.
This PR proposes an architecture where this specialization is at the level of the SceneData. I make sure to be as agnostic as possible ot the type of regression in every part of the script meaning that adding a new one will be pretty easy. The only remaining part that is not agnostic is in the Worker file :
This cleans the structure removing object which representation mught break the json. It will need to beenriched it we add new types, but except from this it it fine (could be agnostic too if we add a static function in the data class that return the key we need to clean...)
This is the CLAUDE.ms file I used